Switch to a different murmurhash2 implementation to handle unicode characters #9158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
cc @afshin |
jtpio
commented
Oct 14, 2020
| @@ -0,0 +1,69 @@ | |||
| // Copyright (c) Jupyter Development Team. | |||
There was a problem hiding this comment.
This file is vendored as part of the implementation of the debugger package to avoid increasing the API surface for now.
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Port of jupyterlab/debugger#549
Code changes
This change vendors the implementation of the murmurhash implementation we were using: https://github.com/garycourt/murmurhash-js
This implementation was for ascii strings only: https://github.com/garycourt/murmurhash-js/blob/0197ce38bedac0e05f40b9d7152095d06db8292c/murmurhash2_gc.js#L9
See jupyterlab/debugger#549 for more context.
The vendored implementation is heavily based on the js implementation, but uses a
TextEncoderto encode the string into aUint8Arraybefore running the algorithm, so it behaves the same as the original C++ implementation (used on xeus-python).User-facing changes
Before
After
Backwards-incompatible changes
None