Bug fix for extension watch mode behavior #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Code looks good to me. Thanks! linkcheck failed because of "Temporary failure in name resolution", so completely unrelated. |
|
@meeseeksdev please backport to 3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Mar 2, 2021
blink1073
added a commit
that referenced
this pull request
Mar 2, 2021
…9-on-3.0.x Backport PR #9889 on branch 3.0.x (Bug fix for extension watch mode behavior)
This was referenced Mar 15, 2021
Closed
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #9861
Code changes
Removes previous
remoteEntry.[hash].jsfiles when re-building. The issue seen in #9861 was that webpack did not re-generate the existing file when the source document state returned to the previous state, and therefore thatremoteEntryfile was not the most recent. Tested locally using the reproduce steps in #9861 before and after this change to verify the fix.User-facing changes
Better extension author experience in watch mode
Backwards-incompatible changes
N/A