Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lab config for copy absolute path #405

Merged
merged 4 commits into from
Jul 24, 2023
Merged

add lab config for copy absolute path #405

merged 4 commits into from
Jul 24, 2023

Conversation

pauky
Copy link
Contributor

@pauky pauky commented Jul 18, 2023

add a new lab config, which will get absolute path when copy path.
For jupyterlab/jupyterlab#14842

@welcome
Copy link

welcome bot commented Jul 18, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@pauky pauky mentioned this pull request Jul 18, 2023
Merged
@pauky pauky changed the title feat(config): add lab config for copy absolute path add lab config for copy absolute path Jul 18, 2023
fcollonval
fcollonval reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pauky

I have a minor wording enhancement.

jupyterlab_server/config.py Outdated Show resolved Hide resolved
pauky and others added 2 commits July 20, 2023 10:13
@pauky @fcollonval
Update jupyterlab_server/config.py
96dedfc 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
82c131e 
for more information, see https://pre-commit.ci
@fcollonval
Copy link
Member

Kicking the CI as the code does seems linted

@fcollonval fcollonval closed this Jul 20, 2023
@fcollonval fcollonval reopened this Jul 20, 2023
@pauky pauky requested a review from fcollonval July 24, 2023 07:30
fcollonval
fcollonval approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pauky

@fcollonval fcollonval merged commit de8f61e into jupyterlab:main Jul 24, 2023
@welcome
Copy link

welcome bot commented Jul 24, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval
Copy link
Member

@pauky --> This got published in https://github.com/jupyterlab/jupyterlab_server/releases/tag/v2.24.0 😉

However for the feat' in JupyterLab, you will need to wait for the next minor version 4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauky @fcollonval