Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail if errors occurred when updating snapshots #175

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Don't fail if errors occurred when updating snapshots #175

merged 2 commits into from
Jan 10, 2023

Conversation

fcollonval
Copy link
Member

Making integration tests robust for snapshots update can be more challenging as the actions are executed faster than in the test.

This PR makes the action forgiving.

@blink1073 blink1073 added the enhancement New feature or request label Jan 10, 2023
blink1073
blink1073 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6a7248a into main Jan 10, 2023
@blink1073 blink1073 deleted the ft/more-robust-snapshots-update branch January 10, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @blink1073