Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continue-on-error configuration #178

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix continue-on-error configuration #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/update-snapshots/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ inputs:
required: false
default: chromium
continue_on_error:
description: Whether to continue on error when updating snapshots or not.
description: Whether to continue on error when updating snapshots or not (one of [`yes`, `no`]).
required: false
default: true
default: yes
dry_run:
description: Whether this is a dry run (one of [`yes`, `no`])
required: false
Expand Down Expand Up @@ -77,7 +77,7 @@ runs:

- name: Generate new snapshots
# Get as much update as possible
continue-on-error: ${{ inputs.continue_on_error }}
continue-on-error: ${{ inputs.continue_on_error == 'yes' }}
shell: bash -l {0}
working-directory: ${{ inputs.test_folder }}
run: yarn run ${{ inputs.update_script }}
Expand Down