Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Python to 3.9 #253

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Bump min Python to 3.9 #253

merged 1 commit into from
Dec 17, 2024

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 17, 2024

3.8 has been EOL for 2+ months.

3.8 has been EOL for 2+ months.
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Carreau
Copy link
Contributor Author

Carreau commented Dec 17, 2024

I unfortunately can't merge.

@Carreau
Copy link
Contributor Author

Carreau commented Dec 17, 2024

(also this is one of the reasons jupyter-event CI fails.

I would personally be more agressive and would have already dropped 3.9

@krassowski krassowski changed the title Bump min Python to 3.9; Bump min Python to 3.9 Dec 17, 2024
@krassowski krassowski merged commit 7b3ab8e into jupyterlab:main Dec 17, 2024
26 of 27 checks passed
@krassowski
Copy link
Member

@krassowski
Copy link
Member

(also this is one of the reasons jupyter-event CI fails.

Strictly the python version can be set via an argument, but yes 3.9 should be the default now.

@Carreau
Copy link
Contributor Author

Carreau commented Dec 17, 2024

Strictly the python version can be set via an argument, but yes 3.9 should be the default now.

Which is what I did :-) Maybe I should go back to "minimal"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants