Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR script action #37

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

blink1073
Copy link
Contributor

Fixes #36

@blink1073 blink1073 added the enhancement New feature or request label Jan 3, 2022
@blink1073 blink1073 requested a review from jtpio January 3, 2022 01:37
- if: steps.check.outputs.triggered == 'true'
uses: jupyterlab/maintainer-tools/.github/actions/pr-script@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check: does this token refer to the token of the user triggering the event?

To be sure users without commit rights are not able to add commits to PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is my understanding, we should double-check though before adding it to something like JupyterLab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge/release and try this out to confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks!

@blink1073 blink1073 merged commit 24671db into jupyterlab:main Jan 10, 2022
@blink1073 blink1073 deleted the pr-script-action branch January 10, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PR Script an Action and Show Its Usage
2 participants