Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

I was expecting /retro/tree/path/foo.ipynb to open the notebook directly #162

Closed
parmentelat opened this issue Jun 10, 2021 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@parmentelat
Copy link

Problem

I'm considering to use retrolab as a replacement to classic/ in an education-oriented tool, where the capability to open one specific notebook from the outside is paramount

pointing my browser at a URL starting with retro/ I was expecting to be able to open a specific notebook directly

  • like e.g. lab/tree/path/foo.ipynb does

what I observe is the part after tree/ being ignored, i.e. retro/tree/path/foo.ipyn behaves exactly like retro/

is this a bug or by design ?

Proposed Solution

provide the same direct-access capability as vanilla jlab

Additional context

@parmentelat parmentelat added the enhancement New feature or request label Jun 10, 2021
@welcome
Copy link

welcome bot commented Jun 10, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio
Copy link
Member

jtpio commented Jun 10, 2021

Thanks @parmentelat.

This should now have been fixed by #159.

It hasn't been released yet, but you could use this Binder link to try the latest main branch on Binder: https://mybinder.org/v2/gh/jupyterlab/retrolab/main?urlpath=retro/tree

@parmentelat
Copy link
Author

thank you @jtpio this is great ! :)
when do you expect this to make it to pypi ?

may I push one step further and ask you about the ability to apply the same trick on jupytext notebooks ?

this is an issue that I also experience with plain jupyterlab, as I just described in here
https://discourse.jupyter.org/t/opening-a-jupytext-powered-notebook-under-jlab/9545

I expect this to be less straightforward of an answer, let me know if you'd rather I open a new issue about that

@jtpio
Copy link
Member

jtpio commented Jun 10, 2021

when do you expect this to make it to pypi ?

Soon for the 0.3.0 alpha series, waiting for other fixes for 0.2.x.

may I push one step further and ask you about the ability to apply the same trick on jupytext notebooks ?

I think jupytext is out of scope for the retrolab project. It would be better to open a new issue on the jupytext repo directly: https://github.com/mwouts/jupytext

Probably this could be implemented as a server extension.

@jtpio
Copy link
Member

jtpio commented Jun 10, 2021

Closing as answered and fixed, thanks!

@parmentelat
Copy link
Author

thanks!
for the record I'm trying to follow up on this in mwouts/jupytext#803

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants