This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Mimic classic notebook behavior for /tree/<path> #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- Show directory listing if path is a directory - Show notebook if path is a notebook - Return file contents if path is any other file Copied from https://github.com/jupyter/notebook/blob/6fe9755971dba3357054766806d56cb8c6c1bca7/notebook/tree/handlers.py#L39 Fixes jupyterlab#153
9 tasks
For this to properly work we'll probably need #15. |
|
@jtpio yep! It currently just shows base tree view. |
|
Congrats on your first merged pull request in this project! 🎉 |
|
@meeseeksdev please backport to 0.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/retrolab
that referenced
this pull request
Jun 9, 2021
jtpio
added a commit
that referenced
this pull request
Jun 9, 2021
…on-0.2.x Backport PR #159 on branch 0.2.x (Mimic classic notebook behavior for /tree/<path>)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from https://github.com/jupyter/notebook/blob/6fe9755971dba3357054766806d56cb8c6c1bca7/notebook/tree/handlers.py#L39
Fixes #153