Restore backwards compatibility with Sphinx <8 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
working on a release, I just have issues with the pre-release workflow that does the wrong changelog. Investigating. |
|
Release in progress, 0.16.4 yanked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See numpy/numpy#26745 (comment) where I encountered this. #199 ensured compatibility with Sphinx 8 after scipy/scipy#21323 was opened (temporarily pinned in scipy/scipy#21324), but it seems to have broken compatibility with older versions of Sphinx (6 and 7, for example). @steppi, I have restored the original fix from #199, since I can't find older versions of the Sphinx documentation to read through – it seems that they publish just the version from the
masterbranch. These changes should work with both Sphinx 8 and earlier versions.