Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register all kernels in one plugin #107

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Register all kernels in one plugin #107

merged 4 commits into from
Dec 13, 2024

Conversation

trungleduc
Copy link
Collaborator

Closes #106

@trungleduc trungleduc force-pushed the fix-xhr branch 2 times, most recently from 12777c0 to 59a876b Compare August 15, 2024 18:51
jtpio
jtpio reviewed Aug 15, 2024
View reviewed changes
src/index.ts Show resolved Hide resolved
@martinRenou martinRenou added the enhancement New feature or request label Sep 10, 2024
@trungleduc trungleduc marked this pull request as ready for review October 24, 2024 09:33
@trungleduc
Copy link
Collaborator Author

This PR is ready but i think it's safer to release it in a major version

@trungleduc trungleduc added this to the 3.0.0 milestone Oct 24, 2024
@martinRenou martinRenou mentioned this pull request Dec 13, 2024
Merged
martinRenou
martinRenou approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 3a02d65 into jupyterlite:main Dec 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

xhr is called synchronously
3 participants
@trungleduc @jtpio @martinRenou