Skip to content

Commit

Permalink
[NFC][Support] Add FormatVariadic sub-test for validation (llvm#106578)
Browse files Browse the repository at this point in the history
- Add validation subtest that tests assert failures in assert enabled
  builds, and that validation is disabled in assert disabled builds.
  • Loading branch information
jurahul authored Sep 2, 2024
1 parent b47d7ce commit ad30a05
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions llvm/unittests/Support/FormatVariadicTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,23 @@ TEST(FormatVariadicTest, FormatFilterRange) {
EXPECT_EQ("1, 2, 3", formatv("{0}", Range).str());
}

TEST(FormatVariadicTest, Validate) {
#ifndef NDEBUG
#if GTEST_HAS_DEATH_TEST
// If asserts are enabled, verify that invalid formatv calls cause assertions.
EXPECT_DEATH(formatv("{0}", 1, 2).str(), "Expected 1 Args, but got 2");
EXPECT_DEATH(formatv("{0} {2}", 1, 2, 3).str(),
"Replacement field indices cannot have holes");
#else // GTEST_HAS_DEATH_TEST
GTEST_SKIP() << "No support for EXPECT_DEATH";
#endif // GTEST_HAS_DEATH_TEST
#else // NDEBUG
// If asserts are disabled, verify that validation is disabled.
EXPECT_EQ(formatv("{0}", 1, 2).str(), "1");
EXPECT_EQ(formatv("{0} {2}", 1, 2, 3).str(), "1 3");
#endif // NDEBUG
}

namespace {

enum class Base { First };
Expand Down

0 comments on commit ad30a05

Please sign in to comment.