Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cfg command for projects override #29

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

SettingDust
Copy link
Contributor

No description provided.

@juraj-hrivnak juraj-hrivnak self-requested a review October 1, 2024 07:53
Copy link
Owner

@juraj-hrivnak juraj-hrivnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! I requested some changes.

src/commonMain/kotlin/teksturepako/pakku/Main.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/cli/cmd/Cfg.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/cli/cmd/Cfg.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/teksturepako/pakku/cli/cmd/Cfg.kt Outdated Show resolved Hide resolved

// -- PROJECTS --

if (projectArgs.isNotEmpty())
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this if expression.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the name, version and others will be added to this command

src/commonMain/kotlin/teksturepako/pakku/cli/cmd/Cfg.kt Outdated Show resolved Hide resolved
@juraj-hrivnak juraj-hrivnak added the enhancement Enhancement of an existing feature label Oct 1, 2024
@juraj-hrivnak juraj-hrivnak merged commit 292ab86 into juraj-hrivnak:main Oct 1, 2024
1 check passed
@SettingDust SettingDust deleted the feature/cfg-command branch October 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
Status: Done🎉
Development

Successfully merging this pull request may close these issues.

2 participants