Improved label parsing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newlines are now allowed between the label and the first instruction, which allows for much clearer code and output from compilers. If an empty label is found at the end of the file, it is now also treated only as a warning, meaning it still accepts it.
as address, but not as operand (making jumps to such labels impossible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, SicTools allows more styles of using labels.
Labels in new lines
Currently, only this was allowed:
Now SicTools also allows the following examples:
Labels at the end of files
Label can also be empty if at the end of file, in which case SicTools now emits a warning but still parses the file.
Support for labels with underscores
Labels can now contain the underscore character, which was previously not allowed as an operand in instructions.
LLVM
With this patch, SicTools becomes compatible with sic-llvm and sic-clang. Therefore compiling from C and compilers with proper LLVM IR output becomes possible.