Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(currency_conversion): add prometheus metrics for redis and api calls #6768

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(currency_conversion): add prometheus metrics for redis and api calls #6768

wants to merge 2 commits into from

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR will add the metrics for the following things in currency_conversion crate:

  1. Successful Redis write
  2. Successful Primary Api call
  3. Successful Fallback Api call
  4. Unsuccessful Redis write

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Can't be tested as this PR is only adding metrics for the above mentioned things.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 added C-feature Category: Feature request or enhancement A-currency-conversion Area: Currency Conversion labels Dec 6, 2024
@prajjwalkumar17 prajjwalkumar17 added this to the December 2024 Release milestone Dec 6, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Dec 6, 2024
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners December 6, 2024 11:29
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 6, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/utils/currency.rs  39% smaller
  crates/router/src/core/metrics.rs  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-currency-conversion Area: Currency Conversion C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
December 2024 Release
Development

Successfully merging this pull request may close these issues.
1 participant
@prajjwalkumar17