Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 version breaks centos based images #144

Closed
bear0330 opened this issue Apr 15, 2016 · 2 comments
Closed

1.17 version breaks centos based images #144

bear0330 opened this issue Apr 15, 2016 · 2 comments

Comments

@bear0330
Copy link

1.17 moves all s6 binaries to /bin but in CentOS based images, the directory structure is

lrwxrwxrwx.   1 root root     7 Mar 23 17:23 bin -> usr/bin
dr-xr-xr-x.   4 root root  4096 Apr 12 09:52 boot
drwxr-xr-x.  17 root root  3080 Apr 15 11:15 dev
drwxr-xr-x.  98 root root 12288 Apr 12 16:46 etc
drwxr-xr-x.   4 root root  4096 Aug 12  2015 home
lrwxrwxrwx.   1 root root     7 Mar 23 17:23 lib -> usr/lib
lrwxrwxrwx.   1 root root     9 Mar 23 17:23 lib64 -> usr/lib64
drwx------.   2 root root 16384 Jul 22  2014 lost+found
drwxr-xr-x.   2 root root  4096 Aug 12  2015 media
drwxr-xr-x.   4 root root  4096 Aug 12  2015 mnt
drwxr-xr-x.   3 root root  4096 Apr 12 09:57 opt
dr-xr-xr-x. 318 root root     0 Apr 30  2016 proc
dr-xr-x---.  10 root root  4096 Apr 12 18:54 root
drwxr-xr-x.  29 root root   920 Apr 13 03:35 run
lrwxrwxrwx.   1 root root     8 Mar 23 17:23 sbin -> usr/sbin
drwxr-xr-x.   2 root root  4096 Aug 12  2015 srv
dr-xr-xr-x.  13 root root     0 Apr 30  2016 sys
drwxrwxrwt.  22 root root  4096 Apr 15 13:04 tmp
drwxr-xr-x.  13 root root  4096 Mar 23 17:23 usr
drwxr-xr-x.  22 root root  4096 Apr 12 09:58 var

After RUN tar xzf /tmp/s6-overlay-amd64.tar.gz -C /
bin folder will not be a symbolic anymore, and /bin/sh, /bin/bash are all disappeared.

@jprjr
Copy link
Member

jprjr commented Apr 15, 2016

One workaround: you could split extracting the tarball into two commands:

RUN tar xzf /tmp/s6-overlay-amd64.tar.gz -C / --exclude="./bin" --exclude="./sbin" && \
    tar xzf /tmp/s6-overlay-amd64.tar.gz -C /usr ./bin ./sbin

This will keep tar from overwriting symlinks.

I'll get the README updated with this workaround.

jprjr pushed a commit to jprjr/s6-overlay that referenced this issue Apr 15, 2016
jprjr added a commit to jprjr/s6-overlay that referenced this issue Apr 15, 2016
jprjr added a commit that referenced this issue Apr 15, 2016
@glerchundi
Copy link
Member

closing due to inactivity, maybe it's related to #158. lets discuss there.

HowardMei added a commit to HowardMei/s6overlayscripts that referenced this issue Mar 3, 2017
…into upstream

* 'master' of https://github.com/just-containers/s6-overlay: (111 commits)
  add s6-networking
  add aarch64
  add x86
  bump versions, pull in more s6 packages
  feat: wait for services to be up before CMDing
  refactor: S6_ATTRS_FIX_HIDDEN -> S6_FIX_ATTRS_HIDDEN
  fix: of fix of secfix, use new public key fingerprint
  fix: of secfix, almost nothing works the first time
  secfix: encryption keys (with iv) were leaked in travis logs
  Add S6_ATTRS_FIX_HIDDEN environment variable
  Fix attributes also for hidden items
  fix: revert back and don't use /bin in with-contenv
  license: use ISC as our license
  Fix for just-containers#150
  Adding armhf builds
  Version bumps
  New S6_CMD_ARG0 variable to prepend CMD when passed to /init
  Preserve semantic of printcontenv when S6_KEEP_ENV is set
  Add new S6_KEEP_ENV mode
  Updating README for issue just-containers#144
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants