Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: update to angular 12 #980

Merged
merged 3 commits into from
May 14, 2021
Merged

chore(deps)!: update to angular 12 #980

merged 3 commits into from
May 14, 2021

Conversation

sonallux
Copy link
Contributor

@sonallux sonallux commented May 14, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Update to angular 12

What is the current behavior?

Angular 12 is not supported

Issue Number: #972

What is the new behavior?

  • Updated all angular dependencies to Angular 12
  • Updated examples to Angular 12
  • Bump minimum supported NodeJS version to 12.14.0 because Angular 12 no longer supported NodeJS 10
  • Update html-webpack-plugin in example, because the current version is not compatible with webpack 5

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

fixes #972

BREAKING CHANGE: update to angular 12
@sonallux sonallux changed the title chore(deps)!: update to angular 12 WIP: chore(deps)!: update to angular 12 May 14, 2021
@nukithelegend
Copy link

Webpack should probably be updated too?

@sonallux
Copy link
Contributor Author

Webpack should probably be updated too?

Webpack is already updated because the dependency to Webpack 5 is contained in the angular package.

@sonallux sonallux marked this pull request as ready for review May 14, 2021 10:54
@sonallux sonallux changed the title WIP: chore(deps)!: update to angular 12 chore(deps)!: update to angular 12 May 14, 2021
Copy link

@nukithelegend nukithelegend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, hoping this can be merged soon

Copy link
Owner

@just-jeb just-jeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@just-jeb just-jeb merged commit ad2772b into just-jeb:master May 14, 2021
@just-jeb
Copy link
Owner

@all-contributors please add @sonallux for code

@allcontributors
Copy link
Contributor

@just-jeb

@sonallux already contributed before to code

@sonallux sonallux deleted the angular-12 branch May 14, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants