-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add img_hash with phash #834
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r electron-rebuild
feat(config): add --node-gyp-options to set up cmd options
fix 13: fix install script syntax
piercus
previously approved these changes
Apr 12, 2022
piercus
requested changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this very good PR that is both :
- Adding a very important feature
- Is well unit tested
My only concerns are is about a possible regression regarding SIFTdetector, and the CI coverage of OpenCV 4.5
- could you please try to use
if CV_VERSION_LOWER_THAN(4, 0, 0)
in order to keep SIFT Detector (see example) - Also please check my comments on Fix #750 making it compatible with Opencv 4.4 #762 (comment) , i feel opencv 4.5 is not covered by current CI, can you ad it ?
What do you think ?
Last merged pr from justadudewhohacks/opencv4nodejs
nothing in My fork about this PR. Keep an 👀 on it. |
Fix typos in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added img_hash module with just only phash since I need it so much. I commented
"cc/xfeatures2d/SIFTDetector.cc"
and related code as #805 (comment) in OpenCV 4.5.0. I don't think it is a good way for Pull Request but I believe some guy needs this as a workaround. I want the great maintainer comes up someday and edits this code as well. :)