Constructor of BaseResource is now final

justbetter · Nov 30, 2022 · 1935d33 · 1935d33
1 parent 59e7709
commit 1935d33
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/OData/BaseResource.php b/src/OData/BaseResource.php
@@ -14,7 +14,6 @@
 use SaintSystems\OData\Entity;
 use SaintSystems\OData\ODataClient;
 
-/** @phpstan-consistent-constructor */
 abstract class BaseResource implements ArrayAccess, Arrayable
 {
     use HasData;
@@ -26,7 +25,7 @@ abstract class BaseResource implements ArrayAccess, Arrayable
 
     public string $endpoint;
 
-    public function __construct(?string $connection = null, ?string $endpoint = null)
+    final public function __construct(?string $connection = null, ?string $endpoint = null)
     {
         $this->connection ??= $connection ?? config('dynamics.connection');
         $this->endpoint ??= $endpoint ?? config('dynamics.resources.'.static::class, Str::afterLast(static::class, '\\'));

diff --git a/src/OData/Resource.php b/src/OData/Resource.php
@@ -4,8 +4,5 @@
 
 class Resource extends BaseResource
 {
-    public function __construct(string $endpoint, ?string $connection = null)
-    {
-        parent::__construct($connection, $endpoint);
-    }
+    //
 }