Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for deleted products in Magento #9

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Check for deleted products in Magento #9

merged 3 commits into from
Nov 22, 2023

Conversation

VincentBean
Copy link
Member

No description provided.

ramonrietdijk
ramonrietdijk requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@ramonrietdijk ramonrietdijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this update is breaking, having an UPGRADE.md would be nice with the changes involved. I'd personally add the requirement of batches in the README.md as well.

@VincentBean VincentBean merged commit 7c035c5 into main Nov 22, 2023
6 checks passed
@VincentBean VincentBean deleted the feature/check-removed-products branch November 22, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonrietdijk ramonrietdijk ramonrietdijk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentBean @ramonrietdijk