Fix for code incorrectly assuming you have at least 2x pageSize amoun…

…t of reviews (#6)
justbetter · Aug 2, 2023 · 7a86b1e · 7a86b1e
1 parent e82013e
commit 7a86b1e
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/src/Actions/HarvestReviews.php b/src/Actions/HarvestReviews.php
@@ -81,17 +81,20 @@ public function harvest(): void
 
         $total = $firstResponse->json('count')['total'];
 
-        $responses = Http::pool(function (Pool $pool) use ($total, $pageSize, $auth) {
-            foreach (range($pageSize, $total, $pageSize) as $page) {
-                $pools[] = $pool->withHeaders($auth)->get(config('feedback-company.api_url') . '/review', [
-                    'limit' => $pageSize,
-                    'start' => $page,
-                ]);
-            }
-            return $pools;
-        });
+        if($total > $pageSize) {
+            $responses = Http::pool(function (Pool $pool) use ($total, $pageSize, $auth) {
+                $pageRange = $total > $pageSize * 2 ? range($pageSize, $total, $pageSize) : [ $pageSize ];
+                foreach ($pageRange as $page) {
+                    $pools[] = $pool->withHeaders($auth)->get(config('feedback-company.api_url') . '/review', [
+                        'limit' => $pageSize,
+                        'start' => $page,
+                    ]);
+                }
+                return $pools;
+            });
+        }
 
-        foreach(array_merge([$firstResponse], $responses) as $response) {
+        foreach(array_merge([$firstResponse], $responses ?? []) as $response) {
             $this->saveReviews($response->json('reviews'));
         }