-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RED-2026] Set a default user agent so Zendesk can identify the requests #323
[RED-2026] Set a default user agent so Zendesk can identify the requests #323
Conversation
…ing from this SDK
@fbvilela This header is fine by me. Although, I am curious what the use case is for knowing requests are coming from this client, in particular? As I understand it, this header lets servers identify the application/OS/vendor of the requesting user. This client is just a wrapper/helper for a consuming application. Would Zendesk not be more interested in what that consuming application is? E.g. "justeat.application1"? And then Zendesk would know all requests from justeat via the Also, if Zendesk did care about requests from this client, what about the case where one of our consumers chooses to overwrite this header? I believe they can using the HttpClientFactory. In this case you wouldn't know these requests were made using this library. I guess what I'm saying is: it makes sense to force consumers to use this header, if we go down this route? Not sure if that makes sense! Happy to hear thoughts/opinions |
Hi @mikerogers123 , |
Hi @fbvilela thanks for the context - super useful. Makes sense. I believe it is possible for a consumer to control this header value if they were to instantiate the client via [ZendeskApiClientFactory.cs] (https://github.com/justeat/ZendeskApiClient/blob/master/src/ZendeskApi.Client/ZendeskApiClientFactory.cs), but it is super unlikely seeing as the consumer would have to register a HttpClient named So yes I am good with this change! Can you bump the version? |
develop -> master (#323)
Description
Sets a default user agent.
We can now see it in our logs the requests are coming from this SDK .
@mikerogers123 are you happy with this user agent string?