Move ErrorHandlerMiddleware down next to HandlerInvocationMiddleware, and ensure exceptions are logged #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… failures can be explained
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 84.92% 85.04% +0.12%
==========================================
Files 135 135
Lines 3290 3290
==========================================
+ Hits 2794 2798 +4
+ Misses 496 492 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…in default setup so that it handles errors as a first priority. LoggingMiddleware assumes a handled exception is available in the context, as should others, instead of handling and rethrowing themselves.
gkinsman
changed the title
martincostello
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
ErrorHandlerMiddlewarenext to theHandlerInvocationMiddleware, so that the first thing that happens after executing user code is handling an exception if one is thrown, and adding it to theHandleMessageContextviaSetException.Then, it adds the
HandledExceptionproperty to the log context so that the error is visible to users. This should have been happening before but the test was lying to us, as it had a bug in it: