Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up using directives using Jetbrains Rider #1079

Merged
merged 4 commits into from
Oct 23, 2022

Conversation

PeterKneale
Copy link
Contributor

I noticed rider was pointing out unneeded using references so i used resolved these.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #1079 (224d887) into main (e74693d) will decrease coverage by 33.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1079       +/-   ##
===========================================
- Coverage   84.80%   51.72%   -33.09%     
===========================================
  Files         135      131        -4     
  Lines        3298     3192      -106     
===========================================
- Hits         2797     1651     -1146     
- Misses        501     1541     +1040     
Flag Coverage Δ
linux ?
macos 51.72% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ools/MessageHandling/Dispatch/MessageDispatcher.cs 85.45% <ø> (ø)
...AwsTools/MessageHandling/Dispatch/MiddlewareMap.cs 85.18% <ø> (ø)
...ng/AwsTools/MessageHandling/SnsMessagePublisher.cs 92.50% <ø> (-5.00%) ⬇️
...ing/AwsTools/QueueCreation/ServerSideEncryption.cs 0.00% <ø> (-100.00%) ⬇️
...t/PublishConfig/DynamicPublicationConfiguration.cs 0.00% <ø> (-100.00%) ⬇️
...nt/PublishConfig/StaticPublicationConfiguration.cs 0.00% <ø> (-95.24%) ⬇️
src/JustSaying/Fluent/TopicPublicationBuilder`1.cs 23.25% <ø> (-60.47%) ⬇️
...rc/JustSaying/Fluent/TopicSubscriptionBuilder`1.cs 16.41% <ø> (-70.15%) ⬇️
src/JustSaying/JustSayingBus.cs 93.00% <ø> (-2.80%) ⬇️
src/JustSaying/Fluent/TopicAddressPublisher.cs 0.00% <0.00%> (-100.00%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

martincostello
martincostello previously approved these changes Oct 23, 2022
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Add spaces back.
@martincostello martincostello enabled auto-merge (squash) October 23, 2022 16:10
@martincostello martincostello merged commit a6784e1 into justeattakeaway:main Oct 23, 2022
@PeterKneale PeterKneale deleted the feature/tidy_usings branch October 23, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants