-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1095 Add support to batch operation #1098
GH-1095 Add support to batch operation #1098
Conversation
src/JustSaying/AwsTools/MessageHandling/MessageBatchResponse.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1098 +/- ##
==========================================
- Coverage 86.06% 84.56% -1.51%
==========================================
Files 137 141 +4
Lines 3302 3641 +339
==========================================
+ Hits 2842 3079 +237
- Misses 460 562 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is looking good @lillo42 Sorry we've gone a bit quiet here, do you think this PR is ready? |
@slang25 I think the PR is ready for review now |
Codecov Report
@@ Coverage Diff @@
## main #1098 +/- ##
==========================================
- Coverage 86.27% 83.87% -2.40%
==========================================
Files 137 141 +4
Lines 3308 3660 +352
==========================================
+ Hits 2854 3070 +216
- Misses 454 590 +136
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@lillo42 Are you going to come back to this? I've just found a need for this myself. |
I'm going to close this as it's been dormant for nearly a year now, and shortly open a new PR based on this code as a starting point. |
Add support for batch publishing messages to SNS. Supersedes justeattakeaway#1098. Co-Authored-By: Rafael Lillo <7280959+lillo42@users.noreply.github.com>
Apply outstanding review comments from justeattakeaway#1098.
Add support for batch publishing messages to SNS. Supersedes justeattakeaway#1098. Co-Authored-By: Rafael Lillo <7280959+lillo42@users.noreply.github.com>
Apply outstanding review comments from justeattakeaway#1098.
Add support for batch publishing messages to SNS. Supersedes justeattakeaway#1098. Co-Authored-By: Rafael Lillo <7280959+lillo42@users.noreply.github.com>
Apply outstanding review comments from justeattakeaway#1098.
Add support for batch publishing messages to SNS. Supersedes justeattakeaway#1098. Co-Authored-By: Rafael Lillo <7280959+lillo42@users.noreply.github.com>
Apply outstanding review comments from justeattakeaway#1098.
Add support for batch publishing messages to SNS. Supersedes #1098. Co-Authored-By: Rafael Lillo <7280959+lillo42@users.noreply.github.com>
GH-1095 This PR adds support to batch operation to SNS & SQS
IMessageBatchPublisher
(avoiding breaking changes)Consideration:
Because we need to chuck the batch message and the current supported doesn't have the
Chuck
method, I've copied the current implement from dotnet repositoryTODO: