Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include publisher ARN's when interrogating the publisher #972

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Include publisher ARN's when interrogating the publisher #972

merged 1 commit into from
Feb 4, 2022

Conversation

gkinsman
Copy link
Contributor

@gkinsman gkinsman commented Feb 4, 2022

We encountered a situation in which we wanted to know what topic name is generated from a naming convention, and found that interrogation doesn't emit ARN's or generated topic names. This PR adds them so you can now see what message type is published to an ARN.

@gkinsman gkinsman requested a review from a team as a code owner February 4, 2022 12:28
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #972 (632e653) into main (52ea887) will decrease coverage by 0.25%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   84.27%   84.02%   -0.26%     
==========================================
  Files         131      131              
  Lines        3206     3211       +5     
==========================================
- Hits         2702     2698       -4     
- Misses        504      513       +9     
Flag Coverage Δ
linux 84.02% <60.00%> (-0.26%) ⬇️
macos 52.94% <20.00%> (-0.15%) ⬇️
windows 52.97% <20.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ng/AwsTools/MessageHandling/SqsMessagePublisher.cs 83.92% <20.00%> (-4.76%) ⬇️
...ng/AwsTools/MessageHandling/SnsMessagePublisher.cs 97.50% <100.00%> (+1.39%) ⬆️
src/JustSaying/JustSayingBus.cs 95.80% <100.00%> (-0.03%) ⬇️
...ools/MessageHandling/Dispatch/MessageDispatcher.cs 85.45% <0.00%> (-12.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ea887...632e653. Read the comment docs.

@gkinsman gkinsman merged commit fc2163b into justeattakeaway:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants