Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-monorepo): add missing Volta settings #322

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented Mar 15, 2023

Describe your changes (can list changeset entries if preferable)

  • Add missing Volta settings to package.json

Volta doesn't inherit the settings from the monorepo root as some might expect. cding into any directory will lead node to use whatever version is installed in the developer environment, and this can easily lead to confusion and random outcomes.

References:

pie-docs wasn't updated because it already has the necessary settings.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 40851a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-stylelint-config Patch
@justeattakeaway/pie-eslint-config Patch
@justeattakeaway/pie-button Patch
@justeattakeaway/pie-icons-react Patch
@justeattakeaway/pie-icons-vue Patch
@justeattakeaway/pie-icons Patch
wc-vue3 Patch
pie-storybook Patch
wc-react18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-15 15:16 UTC

@fernandofranca fernandofranca merged commit 38734c2 into main Mar 15, 2023
@fernandofranca fernandofranca deleted the add-volta-settings branch March 15, 2023 15:14
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants