-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/compodoc Ready to generate Angular documentation #76
Conversation
@RSginer — Great work, thank you. Can you please push the following updates to your PR:
Then we can merge your changes. If anything is unclear or you need help, don't hesitate to ask. Thanks in advance! |
…cript in package.json and add docs folder into npmignore
@RSginer — Thank you for the update. I'm now seeing the following error when I try to run [18:26:43] Provided source folder Object] was not found in the current directory
npm ERR! Darwin 16.0.0
npm ERR! argv "/Users/jvandemo/.nvm/versions/node/v6.10.0/bin/node" "/Users/jvandemo/.nvm/versions/node/v6.10.0/bin/npm" "run" "build:docs"
npm ERR! node v6.10.0
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! lib@0.1.0 build:docs: `compodoc -p tsconfig.json -n [object Object] -d docs --hideGenerator`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the lib@0.1.0 build:docs script 'compodoc -p tsconfig.json -n [object Object] -d docs --hideGenerator'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the lib package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! compodoc -p tsconfig.json -n [object Object] -d docs --hideGenerator
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs lib
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls lib
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /Users/jvandemo/Projects/test/lib/npm-debug.log Here you can see that libraryName: {
original: props.libraryName,
kebabCase: props.libraryName
} so you will have to replace Can you make that fix? Thanks again! |
@RSginer — Perfect, thank you. Your PR has been merged and released as v9.1.0. Thank you for your contribution, much appreciated! 👍 |
Quick update: I have added some convenience scripts to generate documentation and bundled them as
For more info: https://github.com/jvandemo/generator-angular2-library#generating-documentation-for-your-library |
@jvandemo I couldnt do it without your help :) I will try to help in everything I can. Thank you! |
@RSginer — My pleasure, thank you for contributing 👍 |
Commented in #71 Implements compodoc to generate documentation for the library. It's working for me here: https://ngbat.github.io/robin-ui/docs/index.html