Add tests for NaN handling #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #19 Summary
|
varon
commented
Feb 5, 2023
Comment on lines
+51
to
+59
| utils::insert_nans(&mut data, 0.05); | ||
| // Test owned vec | ||
| let (min, max) = data.argminmax(); | ||
| assert_eq!(min, 0); | ||
| assert_eq!(max, ARRAY_LENGTH - 1); | ||
| // Test borrowed vec | ||
| let (min, max) = (&data).argminmax(); | ||
| assert_eq!(min, 0); | ||
| assert_eq!(max, ARRAY_LENGTH - 1); |
There was a problem hiding this comment.
This test passes almost all the time, at least on the architecture I'm using.
This likely has to do with assumptions about the sorting of the data.
|
@jvdd - actions required here? |
|
Is superseded by #31 For me it is currently fine to not include nan tests in the integration tests, as this is already quite extensively tested in the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some (failing) tests for NaN handling.
This does work and is standalone, but obviously the tests fail, so do be aware of that prior to merging.
This can either be used as the base branch for other PRs in this series, such as #18 or can be extended here to a complete implementation.