Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation : Korean #118

Open
ktomkim10 opened this issue Jan 5, 2017 · 39 comments
Open

Translation : Korean #118

ktomkim10 opened this issue Jan 5, 2017 · 39 comments

Comments

@ktomkim10
Copy link

ktomkim10 commented Jan 5, 2017

I'd like to translate to Korean!
Anyone who wants to participate, plz feel free to do so. Fork this repo and make pull requests with any part translated
PR for first part(merged) : #119
PR for second part(current) : #132

@jwasham
Copy link
Owner

jwasham commented Jan 5, 2017

Thank you!

Fork the project and make a README-ko.md in translations directory.
Make a pull request to collaborate and commit to.
Let me know when it's ready to pull.

@Hanney-Ryu
Copy link
Contributor

I would like to help with the Korean translation too!

@kination
Copy link
Contributor

kination commented Jan 5, 2017

Hope I could help on this too.

@ktomkim10
Copy link
Author

@jwasham I made pull request with just a few line and link to the issue. Is it enough for beginning?
@Hanney-Ryu @djKooks Of course, I really appreciate your help!

@jwasham
Copy link
Owner

jwasham commented Jan 5, 2017

Yes, I think others can fork and commit to your branch.

@minias
Copy link

minias commented Jan 5, 2017

There is a link to Korean translation.Keep that in mind.
korean translation

@ktomkim10
Copy link
Author

ktomkim10 commented Jan 5, 2017

@minias Thanks! That link would match to a part of 'Follow Along with me' paragraph

@oozoofrog
Copy link

oh so nice works. May be needs some helps. I hope to support this too.

@ktomkim10
Copy link
Author

ktomkim10 commented Jan 5, 2017

@jwasham
Could you add a link for Korean translation with this issue(#118) at main README.md so that more people could participate?

And would it be possible to add me as a contributer for this repo?

@jwasham
Copy link
Owner

jwasham commented Jan 5, 2017

Just added the link @strollkim

@totuta
Copy link

totuta commented Jan 5, 2017

can I join? let me know how I can participate.

@johannalee
Copy link

I'd love to join this project as well!

@ktomkim10
Copy link
Author

ktomkim10 commented Jan 6, 2017

@johannalee @totuta @singcodes
Please fork my repo and send me PR with any part translated!

@spartzames
Copy link
Contributor

spartzames commented Jan 6, 2017

@strollkim
Can I also join your project?

@ktomkim10
Copy link
Author

@spartz90 of course! plz feel free to participate!

@daveleee
Copy link
Contributor

daveleee commented Jan 6, 2017

I'm deeply impressed w this link so I really wanna contribute to make README-ko.md though!

@ktomkim10
Copy link
Author

@daveleee appreciate your help! plz fork and send PR!

@jwasham jwasham mentioned this issue Jan 6, 2017
@daveleee
Copy link
Contributor

daveleee commented Jan 7, 2017

@strollkim How can i be a participant in to the #119 ?

@ktomkim10
Copy link
Author

@daveleee fork my repo and send PR with any part translated! Thanks!

@rilakkim
Copy link

rilakkim commented Jan 9, 2017

@strollkim I'd like to participate in translation too!

@ktomkim10
Copy link
Author

@jwasham
I thinks it is proper to merge this PR and start new one! pretty much part is translated into Korean
pleae merge the PR

@jwasham
Copy link
Owner

jwasham commented Jan 11, 2017

Super! Done.

@buribae
Copy link

buribae commented Jan 30, 2017

@strollkim I want to participate as well. I forked and translated. PR #146.

Please let me know if I'm making changes in a wrong way!

@Kyeongan
Copy link
Contributor

I would like to join and help.

AzimovS referenced this issue in AzimovS/CodingUniversity Mar 3, 2018
@sksosm
Copy link

sksosm commented Mar 7, 2018

Hello, I would like to join, too!!

@L91519
Copy link

L91519 commented Jul 4, 2018

Is this still in progress?? If possible I want to take a part 👍

@jwasham
Copy link
Owner

jwasham commented Oct 14, 2018

Reopening. There is still a lot of work left, and I don't know if there is stuff waiting to be merged.

@jwasham jwasham reopened this Oct 14, 2018
@joonas-yoon
Copy link
Contributor

joonas-yoon commented Dec 1, 2018

is this done? I think the repo was deleted.
@strollkim @jwasham Can i make new repo (on me) to create new pull request for new commits?

@Bittersweet-dev
Copy link

Hi. This repo seems on going but the previous ones(1 and 2) are not alive.
So I forked new one and am having done which is not translated yet.
Anyone who can still contribute please join me.
Any problem exists about this, @strollkim @jwasham @joonas-yoon please let me know.

@joonas-yoon
Copy link
Contributor

Thanks, but still alive.
Make your commit on this pull request(#397)

@hwaseonchoi
Copy link

Hi, I discovered this repo of John Washam and would like to participate in translating it in Korean, if it is still ongoing (as I see I could fork the project !) I know I joined a bit later, but better later than never !

@joonas-yoon
Copy link
Contributor

Hi, my PR #397 was merged and closed. I think you could fork and create new PR from your one :)

@wonkwonlee
Copy link

Hi, if this translation project still going on, I’m down to participate.

@avajiyo
Copy link

avajiyo commented Mar 30, 2021

Hello! I'd like to contribute to translating it to Korean, but the links above seem to be broken.
Could someone please tell me how I can participate? (Sorry if this is a basic question, I'm completely new to Github)
Thanks!

@sk7t5y
Copy link

sk7t5y commented Apr 8, 2021

I would like to join

@roeniss
Copy link

roeniss commented Aug 24, 2021

@jwasham Looks like some contributors are confused where to make a PR. Would you make a official decision?

for example: "you don't consider this issue (#118). Just fork, edit, then push to this repo's master branch".

Actually I'm confused why this PR is still open.

@joonas-yoon
Copy link
Contributor

@roeniss I agree with above comment. but i think all issues about translation are like a sign to gather the people, who want to contribute.

BTW, this is not PR. it's an issue.

you can start your PR for translating, then come here and can notify your contribution to new people :)

@roeniss
Copy link

roeniss commented Aug 24, 2021

@joonas-yoon thank you for correcting my word, I was confused for a second.
Like you said, it would be good to use this issue as sort of a release board and just make their own pr as they go.

@jwasham
Copy link
Owner

jwasham commented Aug 24, 2021

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests