Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on Node 20 #66

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Run on Node 20 #66

merged 3 commits into from
Feb 6, 2024

Conversation

joshstrohminger
Copy link
Contributor

@joshstrohminger joshstrohminger commented Feb 5, 2024

GitHub is no longer going to support running actions on Node 16 and requires upgrading to Node 20 (see blog). This PR addresses that with updates to:

  • action runtime
  • workflows
  • node types

Tests passed when run locally. Closes #65.

I didn't update the version in package.json because I wasn't sure what type of bump was preferred. I'm happy to add another commit to handle it. The official GitHub actions that I've seen are treating this as a major version bump, so up to v2.0.0. Is following their lead acceptable?

Add @types/node to devDependencies to ensure we get the proper version and bump @vercel/ncc to the latest, and update package-lock using `npm install` which also prepares the package.
Copy link
Owner

@jwlawson jwlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for taking the time to fix this!

The official GitHub actions that I've seen are treating this as a major version bump, so up to v2.0.0. Is following their lead acceptable?

Yep following their lead sounds good to me.

@peter-toft-greve
Copy link

This is great news. I look forward to have this merged and tagged

@joshstrohminger
Copy link
Contributor Author

Yep following their lead sounds good to me.

Cool, I bumped the major version.

@jwlawson jwlawson merged commit 8974e9c into jwlawson:master Feb 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20
3 participants