Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#438 - Fix non-anmiated slider #437

Merged
merged 3 commits into from
Jan 24, 2024
Merged

#438 - Fix non-anmiated slider #437

merged 3 commits into from
Jan 24, 2024

Conversation

dbudzins
Copy link
Contributor

@dbudzins dbudzins commented Jan 18, 2024

Description

Small logic fix for problem identified with shelf slider (TileDock) in non-animated mode.

This PR solves #438.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
    - [ ] Unit tests added
    - [ ] Docs updated (including config and env variables)
    - [ ] Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Jan 18, 2024

Visit the preview URL for this PR (updated for commit 9bed444):

https://ottwebapp--pr437-dbudzins-fix-slider-uxln577u.web.app

(expires Sun, 18 Feb 2024 11:04:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@dbudzins dbudzins force-pushed the dbudzins/fix-slider branch from 636c8b8 to e827aff Compare January 19, 2024 10:33
@dbudzins dbudzins closed this Jan 19, 2024
@dbudzins dbudzins reopened this Jan 19, 2024
@dbudzins dbudzins changed the title TESTING - DO NOT MERGE #438 - Fix non-anmiated slider Jan 19, 2024
@dbudzins dbudzins marked this pull request as ready for review January 19, 2024 11:03
@AntonLantukh AntonLantukh merged commit 22b9507 into develop Jan 24, 2024
9 checks passed
@AntonLantukh AntonLantukh deleted the dbudzins/fix-slider branch January 24, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants