Fix / crash when personal shelf data is not valid #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
langemike,
dbudzins,
AntonLantukh and
CarinaDraganJW
|
Visit the preview URL for this PR (updated for commit aee1f36): https://ottwebapp--pr659-fix-crash-when-favor-k0sk5b3n.web.app (expires Sat, 04 Jan 2025 13:25:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
langemike
approved these changes
Dec 5, 2024
ChristiaanScheermeijer
deleted the
fix/crash-when-favorites-data-validation-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two problems with the personal shelves (favorites & watch history) when we try to load an account with invalid data.
The first problem is that the web app crashes while validating the data. This is a bit to aggressive and can be prevented.
When a validation error occurs, it basically means we can't guarantee that the integrity or the origin of the data. So instead of overwriting the data, we now prevent saving the data so we don't accidentally reset the favorites or watch history list.
When this happens, the user isn't notified, but we log an error to the console. We can improve this in the future to show a message to the user in this scenario.