Avoid iterating the RSA_OPT_PARAMS twice

jwt · Oct 30, 2022 · 5be1d79 · 5be1d79
1 parent 3b11042
commit 5be1d79
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/jwt/jwk/rsa.rb b/lib/jwt/jwk/rsa.rb
@@ -168,10 +168,10 @@ def create_rsa_key_using_accessors(rsa_parameters) # rubocop:disable Metrics/Abc
         end
 
         def validate_rsa_parameters!(rsa_parameters)
-          return unless rsa_parameters[:d]
+          return unless rsa_parameters.key?(:d)
 
-          return if RSA_OPT_PARAMS.all? { |k| rsa_parameters.keys.include?(k) }
-          return if RSA_OPT_PARAMS.none? { |k| rsa_parameters.keys.include?(k) }
+          parameters = RSA_OPT_PARAMS - rsa_parameters.keys
+          return if parameters.empty? || parameters.size == RSA_OPT_PARAMS.size
 
           raise JWT::JWKError, 'When one of p, q, dp, dq or qi is given all the other optimization parameters also needs to be defined' # https://www.rfc-editor.org/rfc/rfc7518.html#section-6.3.2
         end