Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherokee KL - PID Lateral Tested, Reduced MinSteer Tested #112

Closed
wants to merge 13 commits into from

Conversation

ngk0
Copy link

@ngk0 ngk0 commented Apr 2, 2024

Miles544 on Comma Discord

Description:
Added PID-based lateral tuning for Cherokee KL Port Fork.
PID Parameters match other Chrysler / Jeeps for now. Kf slightly modified.
Disabled Chrysler "High Min Steer Speed" flag, not a focus of testing.

Tested:
2019 Cherokee KL w/ Prem. Tech Pkg. (ACC, LKAS, Park Assist)

Routes:

  1. 39180e809b48857f/2024-04-02--07-31-25/13
  2. 39180e809b48857f/2024-04-01--19-54-28/5

Notes:

  1. PID Lateral works well, keeps center of lane.
  2. No faults of any kind.

Priorities:

  1. Port accepted by upstream (OP Main)
  2. Explore steering torque limit
  3. White Panda Mod testing <39mph

Copy link

github-actions bot commented Apr 2, 2024

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

@ngk0
Copy link
Author

ngk0 commented Apr 2, 2024

@jyoung8607 I don't know how to use the PR template or even if it applies for what we're doing. Please let me know. Miles544 on Discord.

@jyoung8607
Copy link
Owner

Thank you for testing this! Bringing the Chrysler port current with upstream master involved refactoring the way a lot of parameters are set, so while I'm adopting the suggested PIF tune, I've done so manually instead of merging this PR.

@jyoung8607 jyoung8607 closed this Apr 30, 2024
dkiiv pushed a commit to dkiiv/openpilot that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants