-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherokee KL - PID Lateral Tested, Reduced MinSteer Tested #112
Conversation
It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template. |
@jyoung8607 I don't know how to use the PR template or even if it applies for what we're doing. Please let me know. Miles544 on Discord. |
Thank you for testing this! Bringing the Chrysler port current with upstream master involved refactoring the way a lot of parameters are set, so while I'm adopting the suggested PIF tune, I've done so manually instead of merging this PR. |
This reverts commit 0035126.
Miles544 on Comma Discord
Description:
Added PID-based lateral tuning for Cherokee KL Port Fork.
PID Parameters match other Chrysler / Jeeps for now. Kf slightly modified.
Disabled Chrysler "High Min Steer Speed" flag, not a focus of testing.
Tested:
2019 Cherokee KL w/ Prem. Tech Pkg. (ACC, LKAS, Park Assist)
Routes:
Notes:
Priorities: