Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeep Cherokee 5th Gen Car Logic within CUSW, Tuning, Tested Min_Speed, Tested Steer_Max #116

Open
wants to merge 23 commits into
base: cherokee_kl
Choose a base branch
from

Conversation

ngk0
Copy link

@ngk0 ngk0 commented May 26, 2024

As Briefly discussed on the thread, this PR includes:

  • Validated 14 m/s min. speed
  • Validated maximum torque / Steer_max at 255, implemented in OP, Panda
  • Implemented tuning settings from May 2024 testing in Discord channel. Supported by jyoung8607 and Michael-Perillo. Works well on highways, okay on back-roads.
  • As requested, removed the commented out sections in Panda that you had temp. disabled for testing (around torque command checks). Working without errors with torque limit at 255.
  • Implemented logic in OP and Panda to maintain Chrylser CUSW as a platform and split off Cherokee 5th Gen as a car within the platform. Allows us to differentiate steering settings, speed/tuning settings if discrepancies between model year or car within platform (Chrysler 300?). This logic is not complete as I we are not yet passing the car as an argument into the safety config function. And we're not using the flag approach as other chryslers are using.
  • Did not do anything to change addresses. Assuming all relevant CUSW messages are common between vehicles within CUSW.

I'm not sure if you're interested in pulling in any of this, but I was trying it out to validate the concept and better learn the approach to porting.

Copy link

github-actions bot commented May 26, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@jeepoooo
Copy link

我有这个车是配备了acc和电子转向,这应该怎么安装到op中,怎么进行试验,另外我在中国,无法通过界面安装这个分支,能通过ssh安装吗?(I have this car that is equipped with acc and electronic steering. How should this be installed into the OP and how to test it? In addition, I am in China and cannot install this branch through the interface. Can I install it through ssh?)

@ngk0
Copy link
Author

ngk0 commented May 27, 2024

我有这个车是配备了acc和电子转向,这应该怎么安装到op中,怎么进行试验,另外我在中国,无法通过界面安装这个分支,能通过ssh安装吗?(I have this car that is equipped with acc and electronic steering. How should this be installed into the OP and how to test it? In addition, I am in China and cannot install this branch through the interface. Can I install it through ssh?)

I looked quickly on discord to find a ssh install guide. You should be able to reference this comment and adapt it to reference this repo and fork. https://discord.com/channels/469524606043160576/538741329799413760/1206938908013764648

dkiiv pushed a commit to dkiiv/openpilot that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants