Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_robot_startup] Added commits not included in https://github.com/jsk-ros-pkg/jsk_robot/pull/1792 but included in https://github.com/jsk-ros-pkg/jsk_robot/pull/1883 #102

Open
wants to merge 10 commits into
base: ichikura_sample
Choose a base branch
from

Conversation

tkmtnt7000
Copy link
Collaborator

@tkmtnt7000 tkmtnt7000 commented Nov 1, 2023

jsk-ros-pkg#1883
で追加して
jsk-ros-pkg#1792
に含まれていないコミットを追加しています.(コミットが汚いです.)

@@ -0,0 +1,26 @@
<launch>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはどこかからlaunch されている?であれば、以下のliflog は戻して arg & if かな。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これもarg & ifにします.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

65d5ce9
で対応しました

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読み飛ばしていました.これはどこからも呼び出されてはいませんでした.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants