feat: linter updates and add defdata macro

CHANGELOG.md

@@ -1,11 +1,13 @@
 This is a history of changes to k13labs/clara-rules.
 
 # 1.4.0-SNAPSHOT
+* include linter fixes for `defrule` and `defquery` which were not processing docstrings correctly.
 * `defrule` now defines rules as functions with two arities, no args returns the rule map, and 2 args is the compiled RHS.
 * `clojure.lang.Fn` now implements `clara.rules.compiler/IRuleSource`, and returns a single rule by invoking the like `(a-rule)`.
 * add built-in support to serialize `clojure.lang.Var` so that a rule handler var can be serialized correctly.
 * add function `clara.rules.compiler/load-rules-from-source` to simplify loading rules
 * add `defhierarchy` macro to define hierarchies of facts allowing to easily establish parent/child relationships.
+* add `defdata` macro to define facts and collections of facts in namespaces allowing to easily embed and insert them during mk-session.
 * rename `clear-ns-productions!` to `clear-ns-vars!` since now there are ns-installed vars that are not productions.
 
 # 1.3.2

clj-kondo/clj-kondo.exports/clara/rules/config.edn

@@ -1,5 +1,6 @@
 {:lint-as {clara.rules/defsession clojure.core/def
            clara.rules/defhierarchy clojure.core/def
+           clara.rules/defdata clojure.core/def
            clara.rules.platform/eager-for clojure.core/for
            clara.rules.platform/compute-for clojure.core/for}
  :hooks {:analyze-call {clara.rules/defquery hooks.clara-rules/analyze-defquery-macro

dev/user.clj

@@ -4,8 +4,8 @@
                                     quick-benchmark] :as crit]
             [clara.rules.platform :refer [compute-for]]
             [clojure.core.async :refer [go timeout <!]]
-            [clara.rules :refer [defrule defquery defhierarchy insert!
-                                 insert insert-all fire-rules query
+            [clara.rules :refer [defrule defquery defdata defhierarchy
+                                 insert! insert insert-all fire-rules query
                                  mk-session clear-ns-vars!
                                  derive! underive!]]
             [clara.rules.compiler :as com]
@@ -37,13 +37,15 @@
   []
   [?output <- :thing/result])
 
-(def ^:fact foo
+(defdata foo
   {:type :thing/foo
    :value 1})
 
-(def ^:fact bar
-  {:type :thing/bar
-   :value 2})
+(defdata bar
+  [{:type :thing/bar
+    :value 2}
+   {:type :thing/bar
+    :value 3}])
 
 (time
  (-> (mk-session 'user :fact-type-fn :type)

src/main/clojure/clara/rules.clj

@@ -372,6 +372,17 @@
        (binding [hierarchy/*hierarchy* (atom (hierarchy/make-hierarchy))]
          ~@body))))
 
+(defmacro defdata
+  "Defines a data fact which is stored in the given var. For instance, the following fact is simply a
+  map which is then inserted into the session when the namespace is loaded.
+
+  (defdata default-temperature
+    (Cold. 32))"
+  [name & body]
+  (let [doc (if (string? (first body)) (first body) nil)]
+    `(def ~(vary-meta name assoc :fact true :doc doc)
+       ~@body)))
+
 (defmacro clear-ns-vars!
   "Ensures that any rule/query definitions which have been cached will be cleared from the associated namespace.
   Rule and query definitions can be cached such that if their definitions are not explicitly overwritten with the same