Update fork to match upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current documentation for the resource `github_branch_protection`, it is noted under `required_pull_request_reviews` that: > `dismissal_actors`: (Optional) The list of actor IDs with dismissal access. The correct parameter name is `dismissal_restrictions` in `github/util_v4_consts.go`.
Adds missing attribute references for node_id within the: * repository data source and resource * team data source and resource * user data source
- Adds CONTRIBUTING.md - Adds SECURITY.md - Adds CONTRIBUTING.md - Minimizes README.md
…rently authenticated github user (#261)
* repo webhook url is sensitive * document the reason for marking url sensitive Co-authored-by: kzw <kzw@noreply.github.com>
Co-authored-by: Jeremy Udit <jcudit@github.com>
* CHANGELOG updates ahead of v4.0.0 release * update bug fix for repository ID
prep for automated release process by removing hard-coded date.
add formatting fixes
private is deprecated
…API calls (#589) * Update resource_github_repository_file.go If you have a repository with a high number of commits, you will quickly hit the Github API limit when trying to get all the commits for the repo. Adding the path parameter will limit the commits to only include the file in question, which will significantly reduce the number of API calls. * Fix formatting
Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> fixing github_actions_secret created/updated timestamp Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> docs, adding repo_id attribute for repository Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> s/orginization/organization/ Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> rename file, add in require param to tests Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> Fixing test copy pasta Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com>
* add milestone resource and data source * fix misspell * rebase and fix build errors - update to go-github v32 - use `Owner` instead of `Organization` * update test suite Co-authored-by: Jeremy Udit <jcudit@github.com>
…github_branch_default resource (#194) * Added github_branch_default resource * Fix branch_default example in docs
* Don't check node id for length * Check if node id is valid base 64 Co-authored-by: Willem Gillis <willem.gillis@imec.be>
these jobs all fail and are confusing to contributors when launched from a PR raised by a fork. there are ways to get around this, but will defer until the repository is transferred. disabling for now.
…n time (#609) There are a number of resources that have been marked as `ForceNew: true` out of a desire in "correctness" by those that do not actually understand how these resources are used in the real world and damage that can be done. No one wants to blow up a repository to change something like this, if they need to there is a mechanism built into terraform called [taint](https://www.terraform.io/docs/commands/taint.html). While there are some things that make sense for using `ForceNew` a repository for source control on properties that the API will ignore outside of creation is not one of them. Signed-off-by: Ben Abrams <me@benabrams.it>
Adding a diff suppression function to the branch protection resource to ignore the strict status check field if no contexts have been specified. This resolves the issue with the GraphQL API returning a strict status check value of "true" by default, regardless of contexts being set or not.
Adding Github Apps to actor types in the branch protection resource. NOTE: Apps as an actor type is only available in push restrictions.
* Added `allowsDeletions`and `allowsForcePushes`settings https://developer.github.com/v4/changelog/2020-11-13-schema-changes/ (#1) * complete documentation * update module github.com/shurcooL/githubv4 with `go get github.com/shurcooL/githubv4` * vendor latest githubv4 * add test for deletions and force pushes Co-authored-by: Jeremy Udit <jcudit@github.com>
Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
Small typo in the docs.
…ce (#644) * Fix references to "master" Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com> * Use commit SHA to lookup commit info Currently the provider loops through commits in a repo until it finds the most recent commit containing the managed file. This is inefficient and could lead to you being rate limited if managing a few files that were updated a long time ago. This commit fixes that by storing the commit SHA when updating the file and using that SHA to lookup the commit info instead of looping through all commits. Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
* add v4.1.1 release items * correct semver version * Document Additional Breaking Change For v3.0.0 * add `github_repository_file` bugfix * move to correct release
* add support for enabling github pages * update resource comments * add additional comments in expand methods * add formatting fixes Co-authored-by: Jeremy Udit <jcudit@github.com>
* Add `branch_protection_v3` Resource - add new resource to `website/github.erb` - add new resource to `website/docs/r/<resource>.html.markdown` - add new resource to `github/provider.go` - add tests for resource in `github/resource_<resource>_test.go` - implement new resource in `github/resource_<resource>.go` * fixup! gofmt fixes
* remove github.com/hashicorp/terraform from dependencies * go mod tidy * refactor: execute fmt
Do not silently proceed further on receiving an error response. Signed-off-by: rustyclock <rustyclock@protonmail.com>
My understanding is our use of Terraform Registry makes this failing test unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.