#42: implemented createCsvHeader; extracted CSV_FIELD_DELIMITER

app/src/androidTest/assets/test-export.csv

@@ -0,0 +1,3 @@
+account;category;currency;amount;ref_currency_amount;type;payment_type;payment_type_local;note;date;gps_latitude;gps_longitude;gps_accuracy_in_meters;warranty_in_month;transfer;payee;labels;envelope_id;custom_category
+Cash;Gifts;EUR;190.00;190.00;Income;CASH;Cash;Yay, such a big gift;2023-01-30 09:38:17;;;;0;false;;;10010;false
+Cash;Life events;EUR;-15.00;-15.00;Expenses;TRANSFER;Bank transfer;Ein Beispiel;2023-01-30 09:37:05;;;;0;false;;;6004;false

app/src/main/java/org/secuso/privacyfriendlyfinance/csv/CsvExporter.java

@@ -18,16 +18,17 @@ License, or (at your option) any later version.
 
 package org.secuso.privacyfriendlyfinance.csv;
 
+import androidx.annotation.NonNull;
+
+import org.joda.time.LocalDate;
 import org.secuso.privacyfriendlyfinance.domain.model.Transaction;
 import org.secuso.privacyfriendlyfinance.domain.model.common.Id2Name;
-import org.secuso.privacyfriendlyfinance.domain.model.common.NameWithIdDto;
-
-import java.util.Arrays;
 
 /**
  * converts (list of) {@link Transaction} items to csv format used for export.
  */
 public class CsvExporter {
+    public static final String CSV_FIELD_DELIMITER = ";";
     private final Id2Name<?> id2Category;
     private final Id2Name<?> id2Account;
 
@@ -38,6 +39,17 @@ public CsvExporter(Id2Name<?> id2Category, Id2Name<?> id2Account) {
 
     public String toCsv(Transaction transaction) {
 
-        return transaction.getDate() + "," + transaction.getAmount() + "," + transaction.getName() + "," + id2Category.get(transaction.getCategoryId()) + "," + id2Account.get(transaction.getAccountId());
+        return toCsv(transaction.getDate(), transaction.getAmount(), transaction.getName(),
+                id2Category.get(transaction.getCategoryId()), id2Account.get(transaction.getAccountId()));
+    }
+
+    public String createCsvHeader() {
+        return toCsv("date","amount","note","category","account");
+    }
+
+    @NonNull
+    private String toCsv(Object date, Object amount, Object comment, Object categoryName, Object accountName) {
+        return date + CSV_FIELD_DELIMITER + amount + CSV_FIELD_DELIMITER + comment
+                + CSV_FIELD_DELIMITER + categoryName + CSV_FIELD_DELIMITER + accountName;
     }
 }

app/src/test/java/org/secuso/privacyfriendlyfinance/csv/CsvExporterTest.java

@@ -45,8 +45,8 @@ public void tearDown() throws Exception {
 
     @Test
     public void toCsv() {
-        // date,amount,transaction-name,category-name,account-name
-        String expected = "1999-12-31,10000,My Test Transaction,my test category,my test account";
+        // date,amount,note,category,account
+        String expected = "1999-12-31;10000;My Test Transaction;my test category;my test account";
         Id2Name<NameWithIdDto> id2Account = new Id2Name<>(Arrays.asList(new NameWithIdDto("my test account", 12345L)));
         Id2Name<NameWithIdDto> id2Category = new Id2Name<>(Arrays.asList(new NameWithIdDto("my test category", 54321L)));
 
@@ -56,7 +56,18 @@ public void toCsv() {
                 "My Test Transaction",10000, LocalDate.parse("1999-12-31"),
                 12345L, 54321L);
 
-        String csvLine = exporter.toCsv(transaction).toString();
+        String csvLine = exporter.toCsv(transaction);
+
+        assertEquals(expected, csvLine);
+    }
+
+    @Test
+    public void createCsvHeader() {
+        String expected = "date;amount;note;category;account";
+
+        CsvExporter exporter = new CsvExporter(null, null);
+
+        String csvLine = exporter.createCsvHeader();
 
         assertEquals(expected, csvLine);
     }