Follow directory symlinks in auto deploying manifests (#9288) #10049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorosen
force-pushed
the
follow-auto-deploy-links
branch
from
e546d0c
to
e636b53
Compare
brandond
approved these changes
Apr 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10049 +/- ##
==========================================
- Coverage 48.92% 43.55% -5.37%
==========================================
Files 158 158
Lines 14032 14045 +13
==========================================
- Hits 6865 6118 -747
- Misses 5885 6762 +877
+ Partials 1282 1165 -117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manuelbuil
approved these changes
May 2, 2024
|
BTRFS E2e failure can be ignored. Solved by #10057. You can rebase |
Signed-off-by: Robert Rose <robert.rose@mailbox.org>
rorosen
force-pushed
the
follow-auto-deploy-links
branch
from
e636b53
to
1aac62d
Compare
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I use k3s in NixOS and am affected by #9288, the auto-deploy controller does not follow symlinked directories. This is a little annoying since it's pretty normal to link large parts of the filesystem in NixOS.
Types of Changes
The deploy controller will now follow top-level symlink directories.
Verification
I tested the changes locally.
Testing
I couldn't find unit tests for the deploy controller and hence don't know what would be the best place for tests. Happy to add a test if required.
Linked Issues
User-Facing Change