Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra log in e2e tests #10145

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented May 23, 2024

Proposed Changes

As of today, when running k3s e2e tests, we can see how the server-0 is created. For example:

E2E_NODE_ROLES="server-0 agent-0" E2E_NODE_BOXES="generic/ubuntu2310 generic/ubuntu2310"  vagrant up server-0 &> vagrant.log

But we don't see the same log for the rest of VMs which might be confusing. This PR removes that confusion as now the test will print all vagrant up commands it runs

Types of Changes

Extra logging

Verification

Run an e2e test that creates several VMs and you now should see the vagrant up command for all nodes, not just server-0
Example:

E2E_NODE_ROLES="server-0 agent-0" E2E_NODE_BOXES="generic/ubuntu2310 generic/ubuntu2310"  vagrant up server-0 &> vagrant.log
E2E_NODE_ROLES="server-0 agent-0" E2E_NODE_BOXES="generic/ubuntu2310 generic/ubuntu2310"  vagrant up agent-0 &>> vagrant.log

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner May 23, 2024 13:17
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.67%. Comparing base (811de8b) to head (1ba18ea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10145      +/-   ##
==========================================
- Coverage   48.02%   40.67%   -7.36%     
==========================================
  Files         173      156      -17     
  Lines       14651    14005     -646     
==========================================
- Hits         7036     5696    -1340     
- Misses       6283     7140     +857     
+ Partials     1332     1169     -163     
Flag Coverage Δ
e2etests 36.42% <ø> (-10.16%) ⬇️
inttests 37.00% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants