Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secrets encryption controller #10612

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Background: The improved performance of secrets reencryption via Use higher QPS for secrets reencryption #10571, and a better understanding that the server handlers already exist as a separate go routine enable this PR
  • Remove secrets reencryption controller and incorporate it directly into the handler like the other stages/cli commands.

Types of Changes

Code simplification

Verification

CI still green

Testing

This is covered by existing E2E and integration tests

Linked Issues

#10581

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner July 30, 2024 16:44
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor nits, lgtm otherwise!

pkg/server/secrets-encrypt.go Outdated Show resolved Hide resolved
pkg/server/secrets-encrypt.go Outdated Show resolved Hide resolved
pkg/server/secrets-encrypt.go Outdated Show resolved Hide resolved
pkg/server/secrets-encrypt.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes missing coverage. Please review.

Project coverage is 43.68%. Comparing base (bffdf46) to head (09b0a0b).
Report is 30 commits behind head on master.

Files Patch % Lines
pkg/server/secrets-encrypt.go 0.00% 75 Missing ⚠️
pkg/secretsencrypt/config.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bffdf46) and HEAD (09b0a0b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bffdf46) HEAD (09b0a0b)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10612      +/-   ##
==========================================
- Coverage   49.52%   43.68%   -5.84%     
==========================================
  Files         179      178       -1     
  Lines       14955    14890      -65     
==========================================
- Hits         7406     6505     -901     
- Misses       6193     7189     +996     
+ Partials     1356     1196     -160     
Flag Coverage Δ
e2etests 36.43% <0.00%> (-9.78%) ⬇️
inttests 36.87% <0.00%> (+0.18%) ⬆️
unittests 13.47% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
brandond previously approved these changes Jul 31, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
vitorsavian
vitorsavian previously approved these changes Aug 7, 2024
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nit on error events

pkg/server/secrets-encrypt.go Outdated Show resolved Hide resolved
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola merged commit 85e02e1 into k3s-io:master Aug 26, 2024
29 checks passed
@dereknola dereknola deleted the se_remove_controller branch September 3, 2024 16:59
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 4, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 4, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 6, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 6, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
* Remove secrets encryption controller

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants