Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Check the last 10 commits for upgrade E2E test #11086

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Check the last 10 commits on a branch when looking for a valid aws commit build. When code freeze comes up, the number of PRs merged causes long build queues, meaning that the last 5 commits may not be available for E2E testing.
  • Rework script to use bash array rather than edit a file one line at a time

Types of Changes

E2E

Verification

Testing

Linked Issues

N/A internal improvement

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner October 11, 2024 16:55
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (1ae9ca7) to head (d029b54).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11086      +/-   ##
==========================================
- Coverage   49.83%   43.26%   -6.58%     
==========================================
  Files         178      178              
  Lines       14816    14764      -52     
==========================================
- Hits         7384     6387     -997     
- Misses       6082     7178    +1096     
+ Partials     1350     1199     -151     
Flag Coverage Δ
e2etests 34.46% <ø> (-11.53%) ⬇️
inttests 36.69% <ø> (+0.08%) ⬆️
unittests 13.59% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit c0d661b into k3s-io:master Oct 16, 2024
31 checks passed
@dereknola dereknola deleted the more_commits branch October 23, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants