Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pkg imported more than once #7803

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jun 20, 2023

Proposed Changes

Types of Changes

Verification

pkg is being imported more than once

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@testwill testwill requested a review from a team as a code owner June 20, 2023 07:09
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +2.52 🎉

Comparison is base (fe9604c) 47.14% compared to head (1336b00) 49.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7803      +/-   ##
==========================================
+ Coverage   47.14%   49.66%   +2.52%     
==========================================
  Files         143      140       -3     
  Lines       14509    14447      -62     
==========================================
+ Hits         6840     7175     +335     
+ Misses       6580     6078     -502     
- Partials     1089     1194     +105     
Flag Coverage Δ
e2etests 49.39% <66.66%> (?)
inttests 44.52% <66.66%> (+0.02%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/run.go 45.04% <0.00%> (+2.54%) ⬆️
pkg/deploy/controller.go 61.96% <50.00%> (+2.95%) ⬆️
pkg/cloudprovider/instances.go 68.29% <100.00%> (ø)
pkg/daemons/executor/embed.go 66.66% <100.00%> (ø)

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants