Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to basic/bearer auth when node identity auth is rejected #7836

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

brandond
Copy link
Member

Proposed Changes

Fall back to basic/bearer auth if client cert auth is rejected

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Resolved an issue that caused agents joined with kubeadm-style bootstrap tokens to fail to rejoin the cluster when their node object is deleted.

Further Comments

@brandond brandond requested a review from a team as a code owner June 29, 2023 00:33
@brandond brandond changed the title WIP Fall back to basic/bearer auth when node identity auth is rejected Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 18.18% and project coverage change: +4.30 🎉

Comparison is base (70691a9) 47.12% compared to head (96ed549) 51.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7836      +/-   ##
==========================================
+ Coverage   47.12%   51.43%   +4.30%     
==========================================
  Files         143      143              
  Lines       14509    14524      +15     
==========================================
+ Hits         6837     7470     +633     
+ Misses       6581     5864     -717     
- Partials     1091     1190      +99     
Flag Coverage Δ
e2etests 49.30% <0.00%> (?)
inttests 44.42% <18.18%> (-0.06%) ⬇️
unittests 19.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/clientaccess/token.go 78.96% <ø> (ø)
pkg/agent/config/config.go 53.60% <18.18%> (+2.84%) ⬆️

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandond brandond force-pushed the fix-bootstrap-token-rejoin branch from 453559b to a5ebdbf Compare July 3, 2023 19:15
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the fix-bootstrap-token-rejoin branch from a5ebdbf to 96ed549 Compare July 3, 2023 19:50
@brandond brandond merged commit 7f50b40 into k3s-io:master Jul 3, 2023
6 checks passed
@brandond brandond deleted the fix-bootstrap-token-rejoin branch June 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants