-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust default kubeconfig file permissions #7978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
changed the title
[WIP] Adjust default kubeconfig permissions
[WIP] Adjust default kubeconfig file permissions
Jul 14, 2023
brandond
requested changes
Jul 14, 2023
Signed-off-by: Derek Nola <derek.nola@suse.com>
osodracnai
approved these changes
Jul 14, 2023
brandond
approved these changes
Jul 14, 2023
dereknola
changed the title
[WIP] Adjust default kubeconfig file permissions
Adjust default kubeconfig file permissions
Jul 14, 2023
Merging, arm CI runners are currently full. |
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 14, 2023
* Adjust default kubeconfig permissions Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 14, 2023
* Adjust default kubeconfig permissions Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 14, 2023
* Adjust default kubeconfig permissions Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
cis-1.24 and newer (the upcoming cis-1.7, yes the name is weird) have moved to a more restrictive kubeconfig default. As the folder
var/lib/rancher/k3s/server/cred
containing these files is restricted to root users only, further restricting the files to read only for root does not present a huge change in file access.Types of Changes
Verification
All
.kubeconfig
files should be 600 permissionsTesting
Linked Issues
#7975
User-Facing Change
Further Comments