Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSSA scan enabled #442

Merged
merged 1 commit into from
Apr 14, 2021
Merged

FOSSA scan enabled #442

merged 1 commit into from
Apr 14, 2021

Conversation

idvoretskyi
Copy link
Contributor

Ref.: cncf/foundation#109

Signed-off-by: Ihor Dvoretskyi ihor@linux.com

@k0da
Copy link
Collaborator

k0da commented Apr 14, 2021

@idvoretskyi Hi, can't this action be used instead?

@idvoretskyi
Copy link
Contributor Author

@k0da we can use it, I have no objections.

The workflow in the proposed PR is the same we've used for a while across various CNCF projects, AFAIK https://github.com/marketplace/actions/fossa-action didn't exist at that time. Thanks for pointing it out.

@idvoretskyi
Copy link
Contributor Author

@k0da updated, let's see how it goes.

k0da
k0da previously approved these changes Apr 14, 2021
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job @idvoretsky! please see my comments.

.github/workflows/fossa.yml Outdated Show resolved Hide resolved
.github/workflows/fossa.yml Outdated Show resolved Hide resolved
@idvoretskyi idvoretskyi force-pushed the idvoretskyi-fossa branch 2 times, most recently from a070a33 to b67dd30 Compare April 14, 2021 12:59
@idvoretskyi
Copy link
Contributor Author

idvoretskyi commented Apr 14, 2021

@kuritka comments addressed, but I think @ytsarev has to sign-off his commit :)

UPD. Nevermind, I've squashed the commits.

Ref.: cncf/foundation#109

Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -13,6 +13,7 @@
[![Docker Pulls](https://img.shields.io/docker/pulls/absaoss/k8gb)](https://hub.docker.com/r/absaoss/k8gb)
[![Artifact HUB](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/k8gb)](https://artifacthub.io/packages/search?repo=k8gb)
[![doc.crds.dev](https://img.shields.io/badge/doc-crds-purple)](https://doc.crds.dev/github.com/absaoss/k8gb)
[![FOSSA Status](https://app.fossa.com/api/projects/custom%2B162%2Fgh.neting.cc%2FAbsaOSS%2Fk8gb.svg?type=shield)](https://app.fossa.com/projects/custom%2B162%2Fgh.neting.cc%2FAbsaOSS%2Fk8gb?ref=badge_shield)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ytsarev had the same, but also received invite to fossa, after that I'm able to see the page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ytsarev it's public now, however, I've invited you all to FOSSA as well (check your inbox for an invite, or DM me via the CNCF Slack).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ytsarev
Copy link
Member

ytsarev commented Apr 14, 2021

@kuritka comments addressed, but I think @ytsarev has to sign-off his commit :)

UPD. Nevermind, I've squashed the commits.

cool, thanks a lot :)

@ytsarev ytsarev merged commit 04dc5c5 into k8gb-io:master Apr 14, 2021
@idvoretskyi idvoretskyi deleted the idvoretskyi-fossa branch November 17, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants