add/remove VDPA devices #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amorenoz please take a look |
amorenoz
reviewed
Oct 7, 2022
|
I messed up while rebasing from master. I'll cherry-pick my changes and tidy up the commit messages |
lmilleri
force-pushed
the
kvdpa_add_device
branch
from
dc8d2a7
to
473de32
Compare
|
@amorenoz Please review it again, I fixed the rebase issue, commit history and few minor changes you requested |
|
I've fixed an issue with golangci-lint. Please rebase to see if tests pass. |
lmilleri
force-pushed
the
kvdpa_add_device
branch
from
d7351b2
to
e0abd50
Compare
This change allows the user (cli) to create a new VDPA device CLI command: kvdpa-cli add [mgmtdev] [dev] mgmtdev: the VDPA management device (e.g. pci/0000:65:00.2) dev: the VDPA device (e.g. vdpa1) Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
This change allows the user (cli) to delete a VDPA device CLI command: kvdpa-cli del [dev] dev: the VDPA device (e.g. vdpa1) Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
function name: GetVdpaDevicesByPciAddress arguments: pciAddress string return values: []VdpaDevice, error Signed-off-by: Leonardo Milleri <lmilleri@redhat.com>
lmilleri
force-pushed
the
kvdpa_add_device
branch
from
e0abd50
to
b605bb5
Compare
|
Rebased from master and rewritten git history to make it cleaner. Please review the changes |
|
Thanks @lmilleri |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the govdpa library by adding the following capabilities:
kvdpa-cli: Add support for new VdpaDevice
This change allows the user (cli) to create a new VDPA device
CLI command: kvdpa-cli add [mgmtdev] [dev]
mgmtdev: the VDPA management device (e.g. pci/0000:65:00.2)
dev: the VDPA device (e.g. vdpa1)
kvdpa-cli: Delete support for VdpaDevice
This change allows the user (cli) to delete a VDPA device
CLI command: kvdpa-cli del [dev]
dev: the VDPA device (e.g. vdpa1)
Added function for returning the VdpaDevice objects for a given pciAddress
function name: GetVdpaDevicesByPciAddress
arguments: pciAddress string
return values: []VdpaDevice, error