Skip to content

Commit

Permalink
Add more logs for rdma selector
Browse files Browse the repository at this point in the history
  • Loading branch information
Mmduh-483 committed Apr 20, 2020
1 parent 8a1d53f commit 0f237f1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
4 changes: 4 additions & 0 deletions pkg/factory/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,17 @@ func (rf *resourceFactory) GetDeviceFilter(rc *types.ResourceConfig) (interface{
if err := json.Unmarshal(*rc.Selectors, netDeviceSelector); err != nil {
return nil, fmt.Errorf("error unmarshalling NetDevice selector bytes %v", err)
}

glog.Infof("net device selector for resource %s is %+v", rc.ResourceName, netDeviceSelector)
return netDeviceSelector, nil
case types.AcceleratorType:
accelDeviceSelector := &types.AccelDeviceSelectors{}

if err := json.Unmarshal(*rc.Selectors, accelDeviceSelector); err != nil {
return nil, fmt.Errorf("error unmarshalling Accelerator selector bytes %v", err)
}

glog.Infof("accelerator device selector for resource %s is %+v", rc.ResourceName, accelDeviceSelector)
return accelDeviceSelector, nil
default:
return nil, fmt.Errorf("unable to get deviceFilter, invalid deviceType %s", rc.DeviceType)
Expand Down
7 changes: 6 additions & 1 deletion pkg/netdevice/netDeviceProvider.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package netdevice

import (
"fmt"
"os"
"strconv"

"github.com/golang/glog"
Expand Down Expand Up @@ -174,14 +175,18 @@ func (np *netDeviceProvider) GetFilteredDevices(devices []types.PciDevice, rc *t

// filter for rdma devices
if nf.IsRdma {
if _, err := os.Stat("/dev/infiniband"); err != nil {
glog.Warningf("%s requires rdma, but \"/dev/infiniband\" is not found", rc.ResourceName)
}

rdmaDevices := make([]types.PciDevice, 0)
for _, dev := range filteredDevice {

if dev.(types.PciNetDevice).GetRdmaSpec().IsRdma() {
rdmaDevices = append(rdmaDevices, dev)
}
}
filteredDevice = rdmaDevices

}

// convert to []PciNetDevice to []PciDevice
Expand Down

0 comments on commit 0f237f1

Please sign in to comment.